Edit Proforma Invoice Via Invoices Model Cause Invoice Status To Active Invoice

[Blesta Addons]

we have a voided invoice .
 
when we  add a public_note via invoices model to a voided invoice ,  the invoice status back to active .
 
the code used is :

$this->Invoices->edit($invoice_id, array('note_public' => "test a note"));

NOTE : the invoice type is proforma .
NOTE 2 : tested with invoice an active proforma .

so any proforma invoice when e edit it via the model invoice with out set the invoice status , it convert to active invoice even if is not tottaly paid .

[Blesta Addons]

the bug is related to function getNextInvoiceVars()  n this code

elseif ($vars['status'] == "proforma" || (($new || (isset($vars['prev_status']) && in_array($vars['prev_status'], array("void", "draft")))) && $client_settings['inv_type'] == "proforma")) {
   $vars['status'] = "proforma";
   $inv_format = $client_settings['inv_proforma_format'];
   $inv_start = $client_settings['inv_proforma_start'];
  }

the function return back the status to proforma and remove the void status .

[Blesta Addons]

UPDATE :

the bugs is not related only to voided proforma, also to active proforma invoice .

if the status is not set in the $vars , the invoice is converted to active invoice .

this will cause a serious law problems for us , as proforma is not paid and converted to invoice, the client is required to pay it even if he doesn't want to renew or pay the services the proforma is for . and the client claim because they have not yet decided to pay or not , and we issue them a invoice without their acceptance .
 

we are working a lot with invoice model , to edit private/public notes, date due ... ect

 

PLEASE A QUICK FIX AS SOON AS POSSIBLE .

[Tyson]

Is this an issue from the UI in Blesta, or when you pass your own call to Invoices::edit? If the latter, it sounds like the work-around is to always set the invoice status.

[Blesta Addons]

As mentioned in my first post . This is for using the invoice model .

 

Passing status with the vars will cause a new database request for get() .

So i prefer in some cases only work with one shoot

[Blesta Addons]

this issue has caused a serious problems .

when we set a note to a voided proforma invoice it back again to open status even if we set status to void in the call

$this->Invoices->edit($invoice_id, [
			'note_public' => "Some Note",
			'status' => "void"
		]);

how to reproduce the case,

void a proforma invoice, via a model call the above code . the proforma invoice status back to open !!!!

[Blesta Addons]

this issue  has more thing to review .....

editing a proforma via Invoices->edit(); change the proforma status to invoice . let say we want to add public_note to proforma , , a change via the model convert the proforma to invoice !!!

 

        $this->Invoices->edit($invoice_id, ['note_public' => "puvlic note here");

 

i think is so logical do not change the status if no status was passed to $vars !? really we have understand the logic of blesta team about changing invoices/proforma .!

 

 

[Paul]

2 hours ago, Blesta Addons said:

this issue  has more thing to review .....

editing a proforma via Invoices->edit(); change the proforma status to invoice . let say we want to add public_note to proforma , , a change via the model convert the proforma to invoice !!!

 

        $this->Invoices->edit($invoice_id, ['note_public' => "puvlic note here");

 

i think is so logical do not change the status if no status was passed to $vars !? really we have understand the logic of blesta team about changing invoices/proforma .!

 

 

Did this work in 3.6? I don't think we changed anything to do with proforma invoices in v4.

[activa]

WE are concerned about this issue in 3.6 .

[activa]

Firstly we have thinked that this issue is linked to blesta addons plugin , but it seem related to core invoice .

Normally we have a plugin that we use to add comment to a voided proforma, and we  have found every commented proforma back to open.

[Blesta Addons]

Who use the plugin "cancel unpaid order" with proforma enabled also concerned with this issue . we will try to make a temporary fix without touching the core files . but this issue should be fixed by the core.

i think is time to implement the TRUE EU invoices system now .