Deliver Invoices Immediately If They Are Set To Email On Manual Creation

[Blesta Addons]

as the title say .

 

THIS CASE IS ONLY FOR MANUAL INVOICE CREATION IN ADMIN SIDE .

 

when creating invoice manually from admin side , there are option "Invoice Delivery" and a checkbox "email" , when we shoose email , and saving/creating invoice , so the invoice well created , and added to queue mail delivery (it should be delivered after some time (no more than 5 minute) .

 

so we need the invoice to be emailed after the creation of invoice  immediately . (this feature was exist in v 2.5 ) .

 

our case , we have some potential users that call our staff by phone to create a proforma invoice for them , after the creation of invoice they consult the email to check the proforma, and then confirm it by phone to be executed - that was in v2.5 ) , in v3 , and from the test period , my staff toll to our clients please wait some time to recieve the email , then call us again to confirm , that was a something borred to our clients , because they always when they end call , theyfinish the order and confirmation , now they ned to call 2 times , and is a task plus for our staff (the time matter in our  work ) .

 

 

NOTE : in the test persiod i have not make any attention to the send invoice from the client profile page , but any way i preffer to be snt immediatly rather than exit and select to send it .

 

 

[Michael]

Not really a fan mate, so I won't plus it up because if you have a cron running and auto send one it could cause load issues etc. That's why I like the 5 minutes cron so it only uses a lot once every 5 minutes.

[Tyson]

so we need the invoice to be emailed after the creation of invoice  immediately . (this feature was exist in v 2.5 ) .

 

our case , we have some potential users that call our staff by phone to create a proforma invoice for them , after the creation of invoice they consult the email to check the proforma, and then confirm it by phone to be executed - that was in v2.5 ) , in v3 , and from the test period , my staff toll to our clients please wait some time to recieve the email , then call us again to confirm , that was a something borred to our clients , because they always when they end call , theyfinish the order and confirmation , now they ned to call 2 times , and is a task plus for our staff (the time matter in our  work ) .

 

 

NOTE : in the test persiod i have not make any attention to the send invoice from the client profile page , but any way i preffer to be snt immediatly rather than exit and select to send it .

 

I take it that creating the invoice (with no delivery option checked), and then delivering it manually from the client profile is not suitable to work around this case?

 

If this feature were implemented, would checking the delivery option for Email then cause the email to be delivered immediately rather than queuing it for delivery?

 

CORE-1561 exists to re-queue a paid proforma invoice to be sent via email if it was queued for email to begin with. If your feature were created to deliver the invoice immediately rather than queue it for delivery, then CORE-1561 would (likely) incur undesirable behavior where the manual creation of a proforma invoice would not later queue the invoice for delivery via email after it has been paid.

[Blesta Addons]

If this will cause a lot of probleme , ingore it , i will try to find my own solution .

But just to enrich this discussion , why not to add new field in invoice , let say 'sended' , put it in false per default , if invoice sended put it true , if proforma converted to invoice then reput it to false , this way the invoice will be ready to sent again , this is just my 2cent in this behavior .

This because i think you have made a complicated/ugly system for invoice delivery . But is working

[Blesta Addons]

I have found an idea to achieve my request . Not tested and i have not see the code yet . I will create a plugin to be executed in invoice.add event , then i will check the valeu of the get.admin . If return a id off staff exist that mean the invoice is created by staff , then i will execute the send email function . Other wise nothing to do .

Is this can be done or i have missed something ?

[Blesta Addons]

Not really a fan mate, so I won't plus it up because if you have a cron running and auto send one it could cause load issues etc. That's why I like the 5 minutes cron so it only uses a lot once every 5 minutes.

Just to clarify . I m not talkink about the cron delay . Tyson has got my idea , and well descriped the obstacle of it . Not a cron subject .

[PauloV]

I understand naja7host dilema

 

I also like to execute imediate an action wen is added manually, in this case on manual adding an invoice, or even creating a service etc.., execute imidiatly the action and do not wait 5 minuts for the cron to run

[serge]

The contradiction is here, some people want some Blesta's tasks are done immediately, when in my opinion it's more effective at process control & management to operate by batch list, most system having a lot of tasks work this way to operate safely (Blesta ever do this way), and never-mind if batch frequency is short.
All domain name registry are doing process by batch list & short job frequency...are you waiting 5 mins for your Registrar, register your domains, will you accept that?
So just make shorter the Blesta cron frequency & Blesta's cron interval can do the job. It will not really consume more resources if there is no task to do, and even if Blesta has its own locking mechanism to prevent race conditions, just in case, I added a deadly simple layer of protection in front for preventing to do not run more than one instance of Blesta's cron:
See my last post here: http://www.blesta.com/forums/index.php?/topic/2990-email-not-being-sent-on-invoice-creation/page-2