Invoice Delivery Log Showing Improper Data

[Chance]

Viewing Tools -> Logs -> Invoice Delivery

The Date Sent column shows valid date/time where invoices have actually been delivered.  Which is good.

The bug is that this column will show whatever the current date/time is for ANY records (paper or email) that have NOT yet been sent.  If I am viewing this log, I should NOT see a date in this column if the invoice has NOT been delivered yet.  In this scenario, the Date Sent column should be something like 'Not Yet Attempted', or '-', or something similar to reflect that the associated invoice is EXPECTED to be delivered but has NOT YET been attempted/sent.

Easy fix is in the /app/views/admin/default/admin_tools_loginvoicedelivery.php file.  Line #38 should be changed FROM:

   <td><?php echo $this->Date->cast((isset($invoice_logs[$i]->date_sent) ? $this->Html->safe($invoice_logs[$i]->date_sent) : null), 'date_time');?></td>

TO SOMETHING LIKE:

    <td>
    <?php if( isset($invoice_logs[$i]->date_sent) ) {
        echo $this->Date->cast( $this->Html->safe($invoice_logs[$i]->date_sent), 'date_time');
    } else {
        echo 'Not Yet Attempted';
    }
    ?>
    </td>

The above has addressed the issue for one of our clients but it would be best if Blesta look at this as an official edit of their template file so future updates will have this correction..

 

[Paul]

Thanks, this has been confirmed and the following task created:

https://dev.blesta.com/browse/CORE-5299