LicenseManager and CLI version

[Blesta Addons]

yesterday we have found a issue with one of our licensed plugin, and after a deep look, we found the issue come from LicenseManager.php .

when the cron is running fro web, all thing is good, but when the cron are running from CLI, the issue is that the class can't determine the domain and the ip when it running from CLI . $_SERVER['SERVER_Name'] , $_SERVER['SERVER_ADDR']  and $_SERVER['LOCAL_ADDR']  global variables is only accessible when running through a browser . we have made a simple patch fro the license manager to get domain from blesta.company vars ,

       else if (isset(Configure::get('Blesta.company')->hostname)) {
            $data['domain'] = Configure::get('Blesta.company')->hostname;
        }

the same for ip we have added a patch to resolve the blesta compay, but after this fixe, the LicenseManager still return error for invalid location;

the cause is licensemanager send a wrong info when it run in CLI,

Array
(
    [status] => invalid_location
    [label] => XXXXXX Plugin
    [time] => 1498148289
    [allow_reissue] => 1
    [addons] =>
    [version] => 4.0.1
    [custom] => Array
        (
            [license_type] => onetime
            [cancellation_date] =>
            [license_for] => XXXXXX
            [addon_version] => 1.0.0
        )

    [domain] => Array
        (
            [0] => XXXXX.com
        )

    [ip] => Array
        (
            [0] => XXX.165.XXXX.249
        )

    [path] => Array
        (
            [0] => /home/XXXXXX/public_html/blesta/
        )

    [updates] =>

 

when we run it from web

 

Array
(
    [status] => valid
    [label] => XXXXXX
    [time] => 1498148277
    [allow_reissue] => 1
    [addons] => 
    [version] => 4.0.1
    [custom] => Array
        (
            [license_type] => onetime
            [cancellation_date] => 
            [license_for] => XXXXXX
            [addon_version] => 1.2.0
        )

    [domain] => Array
        (
            [0] => XXXXX.com
        )

    [ip] => Array
        (
            [0] => XXX.165.XXX.249
        )

    [path] => Array
        (
            [0] => /home/XXXXXX/public_html/blesta/
        )

    [updates] => 
)

 

[Blesta Addons]

more debug:

the fucntion @gethostbyaddr($data['ip']) is not reliable, as it return wroong domain instead of the domain if the ip has other reverse name. a sample case is blesta.com

i think the license manager should has another approuch if the file called from CLI, finnaly we have arrived to make ad this to make it workig .

        // Set the IP
        if (isset($_SERVER['SERVER_ADDR'])) {
            $data['ip'] = $_SERVER['SERVER_ADDR'];
        } elseif (isset($_SERVER['LOCAL_ADDR'])) {
            // Windows IIS 7 support
            $data['ip'] = $_SERVER['LOCAL_ADDR'];
        } elseif (isset($_SERVER['SERVER_NAME'])) {
            // If no IP found, perform lookup based on server name
            $data['ip'] = @gethostbyname($_SERVER['SERVER_NAME']);
        } elseif (isset(Configure::get('Blesta.company')->hostname)) {
            $data['ip'] = @gethostbyname(Configure::get('Blesta.company')->hostname);
        }

        // Set the domain if SERVER_NAME is available, otherwise perform lookup based on IP
        if (isset($_SERVER['SERVER_NAME'])) {
            $data['domain'] = $_SERVER['SERVER_NAME'];
        } else if (isset(Configure::get('Blesta.company')->hostname)) {
            $data['domain'] = Configure::get('Blesta.company')->hostname;
        } else {
            $data['domain'] = @gethostbyaddr($data['ip']);
        }

 

[Blesta Addons]

i think a update to the model is needed, either :

1 - correct the way of collecting the info .

2 - allow plugin to accept setting our own info to send (not the custom_data) , but the base info (ip, domain, path), something like setLicenseServerUrl() , why not setLicenseDomain(), setLicenseIP(), setLicensePath() 

[kala]

Same problem here....we have been scratching our head to get a clean solution without enforcing our own patch! 

[Blesta Addons]

2 hours ago, kala said:

Same problem here....we have been scratching our head to get a clean solution without enforcing our own patch! 

you can use my patch to get it working in CLI, or just clone the patched LicenceManger.php and include it in your scripts

[kala]

On 6/30/2017 at 8:51 PM, Blesta Addons said:

you can use my patch to get it working in CLI, or just clone the patched LicenceManger.php and include it in your scripts

Thanks for your suggestion. We have had a talk in our team and we finally implemented it in a different way which is suitable for our envs. Thanks again for your help