Jono

Also https://dev.blesta.com/browse/CORE-5359

I've created a task: https://dev.blesta.com/browse/CORE-5358 Fix is in the task

Is the invoice associated with the renewal paid? It is only after payment that an API request will be sent to the registrar and the expiration date updated.

On plugins/import_manager/components/migrators/whmcs/whmcs_migrator.php line 751 change $this->local->insert('invoices_recur_created', $vars); To $this->local->duplicate('invoice_recur_id', '=', $recurring_id)->insert('invoices_recur_created', $vars); tblinvoiceitems must have records with a duplicate invoiceid-relid pair. Not sure if there's a valid reason for that.

Hi there, just to throw in an update. I'm testing this yesterday and today. Unable to reproduce by simply doing an import with a billable item with multiple invoices. I'll look more into the code and your report to see what specific set of circumstances causes the error.

Confirmed. Try updating app/models/invoices.php around line 1528 from: $items[] = [ 'service_id' => $service_id, 'qty' => $item->qty, 'amount' => $this->Currencies->convert( $item->price, $service->package_pricing->currency, $currency, Configure::get('Blesta.company_id') ), 'description' => $item->description, 'tax' => !empty($item->taxes) ]; To $items[] = [ 'service_id' => $service_id, 'qty' => $item->qty, 'amount' => $this->Currencies->convert( $item->price, $service->override_currency ?? $service->package_pricing->currency, $currency, Configure::get('Blesta.company_id') ), 'description' => $item->description, 'tax' => !empty($item->taxes) ]; I've created CORE-4441 to handle this.

Just to confirm, you have set an override price/currency on the service?

Task to resolve: CORE-4432

To resolve, edit plugins/support_manager/views/default/css/styles.css and add: .card .ticket-reply p { margin-bottom: 1rem; }

This seems to happen on php7.4+. To fix replace vendors/blesta/Parsedown/Parsedown.php line 130 from: $CurrentBlock = null; To $CurrentBlock = ['type' => '', 'element' => ''];

Confirmed: CORE-4431

Confirmed: CORE-4430

I've added CORE-4429 to address this

I've created CORE-4428 to deal with this.

This query should do the trick: UPDATE acl_acl INNER JOIN acl_aco ON acl_aco.id = acl_acl.aco_id SET acl_acl.permission = 'allow' WHERE acl_aco.alias = 'admin_system_staff' AND acl_acl.action = 'editgroup' AND acl_acl.aro_id = 1; Then you can visit admin/settings/system/staff/editgroup/1/ to make sure all appropriate permissions are enabled.

I've created CORE-4412 to address this. In order to patch the current version edit components/invoice_delivery/invoice_delivery.php line 224 from: $this->language, To $invoice->client->settings['language'] ?? $this->language,

It should make it into 5.1.2 and 5.2.0

I was able to reproduce by performing an upgrade in the admin interface (not able to replicate in client interface). To resolve change app/controllers/admin_clients.php around line 5656 from: $invoice_data = $this->makeInvoice( $client, $serviceChange, $pricing->currency, true, $service->id ); To $invoice_data = $this->makeInvoice( $client, $serviceChange, $pricing->currency, true, null ); Cheers

Here's a video of a basic test that I performed on a 4.10.2 installation. https://www.loom.com/share/40f5cd5005cb4799976f603b5175f1b8 As you can see, a queued upgrade created an invoice with no invoice_lines.service_id set. Do you have any suggestions for what I might do differently to reproduce your issue?

Just want to note here that if you don't sell domains you can remove the client card and nav links for the Domain Manager under Settings > Company > Look and Feel > Layout/Navigation.

This error occurs when the new Domain Manager plugin is not install. To resolve, install the Domain Manager or perform the following code changes: In core/Pricing/Modifier/Type/Description/Type/Domain/Domains.php around line 232 replace: try { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($package_id); $package = (isset($tld->tld) ? $tld->tld : $package); } catch (Throwable $e) { // Nothing to do } With Loader::loadModels($this, ['PluginManager']); if ($this->PluginManager->isInstalled('domains', \Configure::get('Blesta.company_id'))) { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($package_id); $package = (isset($tld->tld) ? $tld->tld : $package); } In core/Pricing/Presenter/Items/Service/ServiceDataItems.php around line 139 replace: try { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($packageId); if (isset($tld->tld)) { $fields['_data']['item_type'] = 'domain'; } } catch (Throwable $e) { // Nothing to do } With Loader::loadModels($this, ['PluginManager']); if ($this->PluginManager->isInstalled('domains', \Configure::get('Blesta.company_id'))) { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($packageId); if (isset($tld->tld)) { $fields['_data']['item_type'] = 'domain'; } } In core/Pricing/Presenter/Items/Service/ServiceItems.php around line 118 replace: try { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($packageId); if (isset($tld->tld)) { $fields['_data']['item_type'] = 'domain'; } } catch (Throwable $e) { // Nothing to do } With Loader::loadModels($this, ['PluginManager']); if ($this->PluginManager->isInstalled('domains', \Configure::get('Blesta.company_id'))) { Loader::loadModels($this, ['Domains.DomainsTlds']); $tld = $this->DomainsTlds->getByPackage($packageId); if (isset($tld->tld)) { $fields['_data']['item_type'] = 'domain'; } }

These upgrades are performed through the core? What version of Blesta are you running? My installation does not link invoice lines from an upgrade to the service through invoice_lines.service_id so I've gotta figure out why yours does.

Thanks for the quick response, I'm headed out of the office, but I'll take a look first thing tomorrow morning. Are you able to identify the invoice for the upgrade in the database and see if the invoice_lines.service_id is set? That seems like the only way this could happen.

I have been unable to reproduce, and looking at the code it shouldn't be possible (either in the latest version or 4.10). Invoices for upgrades do not set the invoice_lines.service_id field. The query to select services to suspend does an inner join on invoice_lines.service_id., so it doesn't seem possible. That being said, I'm definitely willing to test again if you have specific steps to reproduce. If so, please provide

Happy to report some progress on this via CORE-4294. I had a quick question for those concerned. Should summary/invoice line items show the full price as in this screen shot: Or should they have the tax subtracted as in this screen shot (note that the full price is shown when selecting the items regardless)